Re: [PATCH -mm 1/2] umh && creds: convertcall_usermodehelper_keys() to use subprocess_info->init()

[Oleg Nesterov]

On 02/26, David Howells wrote:
>
> Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> > +	/*
> > +	 * This is called in context of freshly forked kthread before
> > +	 * kernel_execve(), we can just change our ->session_keyring.
> > +	 */
>
> Ummmm....  What gives you that idea?
>
> You may be sharing init_cred...

How? Without CLONE_THREAD copy_creds() always creates the new
struct cred for the child?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/