Re: [GIT PULL] notification: including fanotify

[Linus Torvalds]

On Sat, 27 Feb 2010, Linus Torvalds wrote:
>
>  (b) the compile has obviously never been tested with any modern gcc 
>      version. I get tons of warnings after the pull, like

In fact, this seems to be due to a commit that explicitly says:

				I do not add -Wpointer-sign to the fsnotify
    code as there are still issues with kstrdup and strlen which would pop
    out needless warnings.

but then the patch actually has

	--- a/fs/notify/Makefile
	+++ b/fs/notify/Makefile
	@@ -1,3 +1,5 @@
	+EXTRA_CFLAGS   += -Wpointer-sign
	+

WTF? Which part of this was tested AT ALL? Clearly there was not even a 
compile test going on.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/