Re: [PATCH 14/28] kgdboc,keyboard: Keyboard driver for kdb with kgdb

From: Jason Wessel
Date: Sat Feb 27 2010 - 22:42:56 EST


Dmitry Torokhov wrote:
>
>> The original logic for putting next to the keyboard.c was because they
>> are both fighting for the same HW. Please let me know if this changes
>> your mind, else I will go ahead and move the keyboard implementation
>> into the kernel/debug/kdb.
>>
>>
>
> It does not behause in 2.6 the driver talking to the i8042 is called
> i8042.c and it is located in drivers/input/serio.
> drivers/char/keyboard.c does not talk directly to hardware anymore and
> pc_keyb.c is long gone.
>
> Given the fact that your code does not implement a character device I do
> not see any reason for it to live in drivers/char.
>

I buy your logic. I have moved the kdb_keyboard.c to
kernel/debug/kdb/kdb_keyboard.c.

Can I assume we have reached closure on this patch for the short term?

Eventually I would like to to get rid of kdb_keyboard.c entirely and
replace it with some kind of way to atomically poll the input devices,
but this is longer term.

Thanks,
Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/