Re: [PATCH] udf: use ext2_find_next_bit

From: Geert Uytterhoeven
Date: Sun Feb 28 2010 - 05:04:23 EST


On Thu, Feb 25, 2010 at 15:29, Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:
> 2010/2/25 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>:
>> On Thu, Feb 25, 2010 at 02:38, Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:
>>> 2010/2/25 Jan Kara <jack@xxxxxxx>:
>>>> On Tue 23-02-10 23:11:13, Akinobu Mita wrote:
>>>>> Use ext2_find_next_bit (generic_find_next_le_bit) to find the set bit
>>>>> in little endian bitmap region.
>>
>> Is any of this in linux-next now?
>>
>> http://kisskb.ellerman.id.au/kisskb/buildresult/2208481/
>> | fs/udf/balloc.c:274: error: implicit declaration of function
>> 'generic_find_next_le_bit'
>
> Yep, Jan's patch caused the build breakage.
>
> Because generic_find_next_le_bit() is not available for all
> archtectures. So we should use ext2_find_next_bit() here.

Most architectures use the definitions in asm-generic, so they're OK.
M68k doesn't. S390 is also affected, and I think arm as well (but there's no
arm all-modconfig build in linux-next, so I'm not 100% sure).

I'm cooking a patch...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/