sparse checking prevented by "net: fix kmemcheck annotations"

From: Stefan Richter
Date: Mon Mar 01 2010 - 07:09:44 EST

Hi all,

the post 2.6.32-rc5, pre 2.6.32-rc6 commit 14d18a81 causes a serious
regression for sparse checks: make C=1 CF="-D__CHECK_ENDIAN__" now
causes sparse to log

include/linux/skbuff.h:357:41: error: invalid bitfield specifier for
type restricted __be16.

I reported this already shortly after this hit the mainline. But back
then I didn't notice that this sparse error causes sparse to remain
silent on all subsequent warnings in a file!

We need to either change sparse to accept this bogus bit field that
occurs in skbuff.h (__be16 protocol:16;), silently or with a warning, or
revert this kmemcheck annotation.

("We" == preferably Eric :-)

skbuff.h is included by lots of drivers, even ones that are not even
networking drivers, notably DVB drivers. None of these drivers can be
checked with sparse's __CHECK_ENDIAN__ at the moment.
Stefan Richter
-=====-==-=- --== ----=
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at