Re: [PATCH] gpio: cs5535-gpio: fix input direction

From: Andres Salomon
Date: Mon Mar 01 2010 - 14:42:35 EST

On Mon, 1 Mar 2010 10:04:19 -0600
Ben Gardner <gardner.ben@xxxxxxxxx> wrote:

> gpio: cs5535-gpio: fix input direction
> The cs5535-gpio driver's get() function was returning the output value.
> This means that the GPIO pins would never work as an input, even if configured
> as an input.
> The driver should return the READ_BACK value, which is the sensed line value.
> To make that work when the direction is 'output', INPUT_ENABLE needs to be set.
> In addition, the driver was not disabling OUTPUT_ENABLE when the
> direction is set to 'input'. That would cause the GPIO to continue to
> drive the pin if the direction was ever set to output.
> This issue was noticed when attempting to use the gpiolib driver to read
> an external input. I had previously been using the char/cs5535-gpio driver.
> This patch should also be applied to 2.6.33.x, as that is the first version
> that contains the gpio/cs5535-gpio driver.
> Signed-off-by: Ben Gardner <gardner.ben@xxxxxxxxx>
> CC: Andres Salomon <dilinger@xxxxxxxxxxxxxxx>

Looked it over and tested it, seems fine to me. Thanks!

Acked-by: Andres Salomon <dilinger@xxxxxxxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at