[tip:x86/atomic] lib: Fix atomic64_add_unless test

From: tip-bot for Luca Barbieri
Date: Mon Mar 01 2010 - 14:58:36 EST


Commit-ID: 9efbcd590243045111670c171a951923b877b57d
Gitweb: http://git.kernel.org/tip/9efbcd590243045111670c171a951923b877b57d
Author: Luca Barbieri <luca@xxxxxxxxxxxxxxxxx>
AuthorDate: Mon, 1 Mar 2010 19:55:45 +0100
Committer: H. Peter Anvin <hpa@xxxxxxxxx>
CommitDate: Mon, 1 Mar 2010 11:38:46 -0800

lib: Fix atomic64_add_unless test

atomic64_add_unless must return 1 if it perfomed the add and 0 otherwise.
The test assumed the opposite convention.

Reported-by: H. Peter Anvin <hpa@xxxxxxxxx>
Signed-off-by: Luca Barbieri <luca@xxxxxxxxxxxxxxxxx>
LKML-Reference: <1267469749-11878-2-git-send-email-luca@xxxxxxxxxxxxxxxxx>
Signed-off-by: H. Peter Anvin <hpa@xxxxxxxxx>
---
lib/atomic64_test.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/atomic64_test.c b/lib/atomic64_test.c
index 58efdab..ee8e6de 100644
--- a/lib/atomic64_test.c
+++ b/lib/atomic64_test.c
@@ -104,11 +104,11 @@ static __init int test_atomic64(void)
BUG_ON(v.counter != r);

INIT(v0);
- BUG_ON(!atomic64_add_unless(&v, one, v0));
+ BUG_ON(atomic64_add_unless(&v, one, v0));
BUG_ON(v.counter != r);

INIT(v0);
- BUG_ON(atomic64_add_unless(&v, one, v1));
+ BUG_ON(!atomic64_add_unless(&v, one, v1));
r += one;
BUG_ON(v.counter != r);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/