Re: [tip:x86/irq] x86: apic: Fix mismerge, addarch_probe_nr_irqs() again

[Ian Campbell]

On Mon, 2010-03-01 at 10:34 -0800, Eric W. Biederman wrote:
> 
> As of 2.6.33 the limitations in DomU support are:
> - xen_evtchn_do_upcall starts with the irq number instead of
>   the irq_desc, and happens to unnecessarily call into arch
>   specific code.  

I saw a patch to fix this one recently, "xen: Remove unnecessary arch
specific xen irq functions.", right?

> - Xen has an array irq_info[NR_IRQS] one of the last static arrays
>   sized at NR_IRQs in the entire kernel.

Hopefully the same info as is in that array could (and indeed should) be
instead stored in irq_desc->chip_data. Would you object to
arch_init_copy_chip_data and arch_free_chip_data becoming function
pointers within the struct irq_chip?

> If you can fix the Xen code so it isn't dragging the rest of the
> kernel down when it comes to large numbers of irqs more power to you.

If you know of other aspects of the Xen code where this is the case (or
find them in the future) please let me know, I'll do my best to fix
them.

Ian.

-- 
Ian Campbell

To the systems programmer, users and applications serve only to provide a
test load.

Attachment: signature.asc
Description: This is a digitally signed message part