RE: [PATCH] i2c-pnx: fix setting start/stop condition

From: Kevin Wells
Date: Mon Mar 01 2010 - 20:12:47 EST

Hi Luotao,

> I had a closer look into this and think that you are right. I was
> irritated by the unregular usage of start_bit and thought the stop bit is
> asserted with the i2c_pnx_stop call, which is apparently only used for
> zero sized transfers.
> Fixed patch is attached with this mail.

This latest patch seems to work fine and tests well with all our
I2C devices - including the pcf8563, which didn't work right before
this patch. I think it's good to go.


> cheers
> Luotao Fu
> --
> Pengutronix e.K. | Dipl.-Ing. Luotao Fu |
> Industrial Linux Solutions | |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at