Re: [PATCH 1/5] DMAENGINE: COH 901 318 cleanups

From: Dan Williams
Date: Tue Mar 02 2010 - 16:06:48 EST


On Tue, Mar 2, 2010 at 1:12 PM, Linus Walleij
<linus.walleij@xxxxxxxxxxxxxx> wrote:
>        if (cohc->nbr_active_done)
> +       /*
> +        * If another interrupt fired while the tasklet was scheduling,
> +        * we don't get called twice, so we have this number of active
> +        * counter that keep track of the number of IRQs expected to
> +        * be handled for this channel. If there happen to be more than
> +        * one IRQ to be ack:ed, we simply schedule this tasklet again.
> +        */
>                cohc->nbr_active_done--;

Checkpatch made a justifiable wimper about this. It looks like you
wanted to delete that if() according to the previous unified patch?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/