Re: [git pull] drm request 2

From: Linus Torvalds
Date: Tue Mar 02 2010 - 18:00:29 EST




On Mon, 1 Mar 2010, Dave Airlie wrote:
>
> Same tree as yesterday with a warning + PPC build fix + fix for build on
> x86 after PPC (I think I just validated Ingo).

Why is VGA_SWITCHEROO enabled by default?

We don't do things like that. New drivers and new features are _not_
enabled by default, unless there is some overriding reason why they should
be. And I don't see that reason.

Please stop doing that. The whole "default y" is a f*cking disease. Yes, a
developer always thinks that _his_ new code is so special and important
that it should be enabled by default, BUT HE IS WRONG.

So remember: unless your new feature cures cancer, it should damn well not
be enabled by default.

I disabled it in the merge, since I had to fix up that file anyway. But
please don't make me do these so-called "evil merges" where I end up
modifying the thing I merge.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/