Re: [git pull] drm request 2

From: Dave Airlie
Date: Tue Mar 02 2010 - 18:17:20 EST

> Never mind. I've unpulled the whole effin' mess since it doesn't even
> compile:
> drivers/gpu/drm/nouveau/nouveau_acpi.c:191: error: redefinition of ʽnouveau_register_dsm_handlerʼ
> drivers/gpu/drm/nouveau/nouveau_drv.h:859: note: previous definition of ʽnouveau_register_dsm_handlerʼ was here
> drivers/gpu/drm/nouveau/nouveau_acpi.c:202: error: redefinition of ʽnouveau_unregister_dsm_handlerʼ
> drivers/gpu/drm/nouveau/nouveau_drv.h:860: note: previous definition of ʽnouveau_unregister_dsm_handlerʼ was here
> because not only was that VGA_SWITCHEROO Kconfig default the wrong way
> around, the thing had clearly never ever been tested at all.
> Why does sh*t like this even make it to me? Was this ever at all in -next?
> I assume not, since that would have picked up on basic compile failures.
> Grr. Things like this is what makes me go "Ok, there's always the next
> merge window, maybe it will have gotten some testing by then".

Linux next didn't pick up this build failure, wierdly neither did the
powerpc build I did with this turned off, because ACPI was also off on
ppc, it was in linux-next for at least 2 days, and from what I can see
that found the ppc problems, it never found the x86 option since it was on
by default.

I'm going to just rip the nouveau bits out of the patch, btw nouveau is in
staging, so you are being a bit OTT, calm down.