Re: [PATCH] Avoid implicit constant truncation
From: Jesse Barnes
Date: Tue Mar 02 2010 - 19:26:58 EST
On Tue, 02 Mar 2010 16:06:33 -0800
Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
> On 03/02/10 16:01, imunsie@xxxxxxxxxxx wrote:
> > From: Ian Munsie <imunsie@xxxxxxxxxx>
> > When building on 64 bit platforms, the compiler throws the following
> > warning:
> > drivers/pci/probe.c:197: warning: large integer implicitly
> > truncated to unsigned type
> > This patch adds an explicit truncation to silence the compiler
> > warning.
> Please see/read/use Documentation/SubmittingPatches. E.g.:
> The canonical patch subject line is:
> Subject: [PATCH 001/123] subsystem: summary phrase
> I.e., the subject: should tell us that this is a PCI: patch.
> (or even pci: -- i don't care which)
No need to resubmit though; I usually have to fix up the summary and
changelog a bit when applying anyway.
That said, this patch rings a bell; I think the warning is signalling a
real bug in the ppc code. IIRC Ben was going to look at it awhile
back, but I think it's mostly harmless so it's probably low on his list.
Jesse Barnes, Intel Open Source Technology Center
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/