Re: aoeblk_make_request() chokes on zero-length barriers

From: Ed Cashin
Date: Wed Mar 03 2010 - 10:47:49 EST

On Wed, Mar 03, 2010 at 01:11:12PM +0900, Tejun Heo wrote:
> Hello, Ed L. Cashin.
> This is reported on openSUSE 11.2 by Lars Tauber on bnc581271[1] but
> upstream code seems to have the same problem. If a bio doesn't have
> bi_io_vec, aoeblk_make_request() triggers BUG() but in recent kernels
> the block layer will happily send down zero-length barrier bios w/o
> bi_io_vec set.

It looks like the opensuse 11.x kernel doesn't have the
change that made aoe return -EOPNOTSUPP for barriers.

It's commit 18d8217bc441630c3c5ec7416c5a65c69e8a0979,
appearing in v2.6.32-rc1.

I have most of a barrier implementation for aoe done
but got sidetracked. I'd welcome any volunteers who
would like to do testing. Please email me directly.

Ed Cashin <ecashin@xxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at