Re: [PATCH] uartlite: Fix build on sparc.

From: Grant Likely
Date: Wed Mar 03 2010 - 10:51:51 EST

On Wed, Mar 3, 2010 at 3:50 AM, David Miller <davem@xxxxxxxxxxxxx> wrote:
> We can get this driver enabled via MFD_TIMBERDALE which only
> requires GPIO to be on.
> But the of_address_to_resource() function is only present on
> powerpc and microblaze, so we have to conditionalize the
> CONFIG_OF probing bits on that.
> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> diff --git a/drivers/serial/uartlite.c b/drivers/serial/uartlite.c
> index ab2ab3c..f0a6c61 100644
> --- a/drivers/serial/uartlite.c
> +++ b/drivers/serial/uartlite.c
> @@ -19,7 +19,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/init.h>
>  #include <asm/io.h>
> -#if defined(CONFIG_OF)
> +#if defined(CONFIG_OF) && (defined(CONFIG_PPC32) || defined(CONFIG_MICROBLAZE))

ARM will probably end up using this driver. How about simply
defined(CONFIG_OF) && !defined(CONFIG_SPARC)?

Or if you prefer, I could expedite my patch that moves
of_address_to_resource() into common code (it's currently in my test
branch). I wasn't planning to merge it until 2.6.35, but it is pretty
low risk so I'd be comfortable merging it now.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at