Re: [PATCH 1/4] dlm: fix ordering of bast and cast
From: David Teigland
Date: Thu Mar 04 2010 - 11:17:46 EST
On Thu, Mar 4, 2010 at 6:41 AM, Steven Whitehouse <swhiteho@xxxxxxxxxx> wrote:
> Some questions on this one... shouldn't the filtering of the basts go at
> the start of dlm_add_ast() so that it catches both the basts heading to
> userspace and the ones going via the kernel interface?
Hm, I'm not sure what happened to the userspace part of this which is
only partly there. Thanks, I'll get that back or done (it's never been a
problem for userspace, but should still be done). It may make sense to
do some of this earlier for both, I'll have to see.
> Also, when the short-cut of generating casts locally on certain remotly
> mastered demote requests is used, does that somehow suppress the
> generation of casts on the lock master?
yes (it's a reply to the convert which is skipped)
> I notice that the variable lkb->lkb_bastmode_done has been added, but is
> only ever assigned to and never read. Was that supposed to have been
> made accessible via debugfs for example?
Yeah, it was used in an earlier version of this patch with a lot more checking
and debugging. I'll see if there's some debugging or checking I could add that
uses it or else remove.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/