Re: [PATCH 2/2] device.h drivers/base/core.c Convert dev_<level>macros to functions
From: Joe Perches
Date: Thu Mar 04 2010 - 21:46:18 EST
dOn Thu, 2010-03-04 at 17:00 -0800, Andrew Morton wrote:
> On Thu, 4 Mar 2010 16:56:09 -0800 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > On Wed, 3 Mar 2010 22:27:23 -0800 Joe Perches <joe@xxxxxxxxxxx> wrote:
> > > Save ~60k in a defconfig
> > > Use %pV and struct va_format
> > > Format arguments are verified before printk
> > Well that doesn't work very well.
> > drivers/net/pcmcia/pcnet_cs.c:117: error: 'dev_info' redeclared as different kind of symbol
> > include/linux/device.h:645: error: previous declaration of 'dev_info' was here
> > there are lots of other dev_info's which will fail plus perhaps
> > dev_err's, etc.
> btw, this may be kludgeable aroundable by doing
> int _dev_info(const struct device *dev, const char *fmt, ...);
> #define dev_info(...) _dev_info(...)
> which will use the preprocessor's separation of `foo' from `foo()' to
> fix things up.
> But it would be better to rename all those dev_info's to device_info or
> whatever, IMO.
Perhaps using the function name _dev_info() and adding
the macro above is an acceptable workaround until the
dev_info struct names or local variable names could be
renamed if necessary.
dev_err and dev_warn exist in source comments only and
don't seem to be a problem.
David Miller? Do you have an opinion on the renaming
of dev_info local variables and structs?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/