vga_switcheroo: locking question in vga_switcheroo_debugfs_write()

From: Dan Carpenter
Date: Sat Mar 06 2010 - 06:04:37 EST

Hi Dave,

drivers/gpu/vga/vga_switcheroo.c +362 vga_switcheroo_debugfs_write(101)
277 mutex_lock(&vgasr_mutex);
279 if (!
280 return -EINVAL;

Is there a reason we return with the lock held here? The other returns
from this function don't have the lock held. I looked through the rest
of the file but didn't see any clues.

dan carpenter
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at