Please pull logfs tree
From: JÃrn Engel
Date: Sat Mar 06 2010 - 16:39:25 EST
in principle this should be a simple pull request. But as Stephen
noted, the logfs tree conflicts with a patch from hch and I am unsure
how best to proceed.
On Mon, 1 March 2010 16:04:45 +1100, Stephen Rothwell wrote:
> I am carrying a few merge fixup patches in linux-next that I thought you
> might want a heads up about. Hopefully, these will be fixed before you
> see them, but just in case, here they are (in no particular order).
> This could also be taken as a reminder to the respective maintiners that
> they may want to do a merge of your tree before asking you to pull theirs.
> 5) The vfs tree modifies the write_inode method API (commit
> 716c28c0bc8bcbdd26e819f38dfc8fdfaafc0289 "pass writeback_control to
> ->write_inode") and the logfs tree adds a write_inode method (commit
> 5db53f3e80dee2d9dff5e534f9e9fe1db17c9936 "[LogFS] add new flash file
> system"), so:
I see three solutions that are remotely sane.
1) pull git://git.kernel.org/pub/scm/linux/kernel/git/joern/logfs.git
and apply the patch at the bottom yourself.
2) pull git://git.kernel.org/pub/scm/linux/kernel/git/joern/logfs_for_2.6.34
A tree with the patch applied that won't work standalone but will work
after being pulled into your tree (tested locally).
3) pull git://git.kernel.org/pub/scm/linux/kernel/git/joern/logfs_for_2.6.34_alternative
A tree that merged your tree and the logfs tree, then has the patch
applied. Works standalone but has an additional merge commit.
I would slightly prefer option 2), but you surely know better.
PS: And trees 2) and 3) haven't made it over from master.kernel.org yet.
Not sure if I made a mistake or simply have to wait longer.
Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it.
-- Brian W. Kernighan