Re: [PATCH 3/4] of/gpio: Implement GPIOLIB notifier hooks
From: Anton Vorontsov
Date: Sat Mar 06 2010 - 20:47:56 EST
On Sat, Mar 06, 2010 at 09:43:20AM -0700, Grant Likely wrote:
> > On Fri, Mar 05, 2010 at 08:54:56PM -0700, Grant Likely wrote:
> > And of course the part of the OF rework, which was first posted
> > for *review* on Feb 03, is a completely different story?
> > Â48 files changed, 317 insertions(+), 575 deletions(-)
> Completely uncontroversial changes with zero functional behaviour
> change. There was no uncertainty about these ones and they were
> posted almost a week earlier.
The patches simply touch too many things, so I'd say that the
possible breakage impact is on par with the OF GPIO stuff.
> > That's a non-argument, what is "lower impact"? Do I touch any
> > hot paths? And if nothing has changed, David (again, the gpiolib
> > maintainer) is happy with the notifiers approach, why would you
> > care?
> Adding unneeded notifier infrastructure is churn I don't want to see.
You could reply to my answers earlier and I would change and
repost the patches in a jiffy, since I am interested in these
But you're obviously not interested in this support since you
didn't answer my replies. I'll explain. If you were interested
in some support you could give some chance to make patches
comfortable to you, and then you could even test them, and
maybe defend their inclusion.
Look at what an interested person does:
Note that that was v2 with my comments fixed, and that was
just seconds before 2.6.33 merge window closed. See?
Someone with a direct interest! I gave my comments, they
were fixed, and I felt grateful and responsible for pushing
the support upstream.
But you're not interested in the support, so I don't see
why you block it without any good technical reason.
And note that not only I'm interested in this support, the
I2C/SPI GPIO controllers issue was brought on ml several
times by many people.
> > I don't get it. Why is it a problem to change your patches that
> > ought to be queued for 2.6.*35*?
> It's not, and they are going to be queued for 2.6.35. In fact, I
> didn't posted them this week to avoid adding confusion to the merge
> window. The issues isn't changing my patches.
Then why you mentioned OF rework as some reason to block
> It is that I don't
> like the notifier approach, and I intend to prove that it can be done
> in a better way.
No doubt that you have some better ideas (not to mention that
notifiers was your idea as well :-).
Here are some technical arguments:
1. You can implement your new ideas on top of the current solution.
Or I can happily do that for you.
2. The patches don't change any API, instead they just build
a bridge between GPIOLIB and OF GPIO infrastructure.
So it's just a matter *taste* how to build that bridge.
It's an internal issue of how GPIOLIB and OF GPIO interact.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/