Re: UML XFS link error list_sort

From: Randy Dunlap
Date: Sat Mar 06 2010 - 22:26:35 EST


Parag Warudkar wrote:
> Hi Dave
>
> While building today's git for CONFIG_UML, I got a link error (list_sort
> undefined) for xfs.ko.
>
> Currently I am working around it with the below hack. Not sure the right
> thing to do would be some where at the arch level for UML or if the below
> would be appropriate.
>
> Parag
>
> diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
> index b4769e4..2905cda 100644
> --- a/fs/xfs/Makefile
> +++ b/fs/xfs/Makefile
> @@ -94,6 +94,8 @@ xfs-y += xfs_alloc.o \
>
> xfs-$(CONFIG_XFS_TRACE) += xfs_btree_trace.o
>
> +xfs-$(CONFIG_UML) += ../../lib/list_sort.o
> +
> # Objects in linux/
> xfs-y += $(addprefix $(XFS_LINUX)/, \
> kmem.o \
> --

I posted a patch for xfs to select LIST_SORT (kconfig symbol)
so that the library is built for it (xfs).

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/