Re: [PATCH] USB: N-trig Finger Pen Multitouch fix

From: Jiri Kosina
Date: Mon Mar 08 2010 - 07:51:31 EST


On Sun, 7 Mar 2010, Micki Balanga wrote:

> The purpose of this patch is to enable Linux users to experience the
> complete N-trig DuoSense pen and true multi-touch solution capabilities
> over a Linux platform. This driver has been carefully and thoroughly
> tested by N-trig, over a period of several months.
>
> N-trig is changing the way people interact with computers by providing a
> dual-mode pen and true multi-touch input device, specifically designed
> for today's advanced computing world. N-trig DuoSense® solution provides
> a real Hands-on computing® experience, and sets the stage for OEMs and
> ISVs to introduce innovative computer products and applications for an
> intuitive, Hands-on® experience directly onscreen. DuoSense digitizers
> are easily integrated into existing technologies, support all LCDs, keep
> devices slim and light, and can be implemented in a broad range of
> products, ranging from small notebooks to large LCDs. N-trig has offices
> in Israel, the US, Taiwan and Japan.
>
> Signed-off-by: Micki Balanga <micki@xxxxxxxxxx>

Thanks for the patch.

As you are very well aware, we already have n-trig driver written by Rafi
Rubin. I understand that your patch is implementing new features that
Rafi's patch is not able to handle, and also re-factoring the driver in a
non-trivial way.

Therefore it would be nice, if you could separate out the individual
changes/additions to be based on top of the driver that we already have,
and accompany them with nice changelog describing what changes are being
done and why

Or even Rafi volunteered to do this, as I can see -- thanks for that! It
would still be nice to get Acked-by from the N-Trig guys for the changes
at least.

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/