Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limitinginfrastructure

From: KAMEZAWA Hiroyuki
Date: Mon Mar 08 2010 - 19:24:42 EST


On Tue, 9 Mar 2010 09:18:45 +0900
Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx> wrote:

> On Mon, 8 Mar 2010 17:31:00 +0900, KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
> > On Mon, 8 Mar 2010 17:07:11 +0900
> > Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx> wrote:

> > Hmm...accepatable ? (sounds it's in error-range)
> >
> > BTW, why local_irq_disable() ?
> > local_irq_save()/restore() isn't better ?
> >
> I don't have any strong reason. All of lock_page_cgroup() is *now* called w/o irq disabled,
> so I used just disable()/enable() instead of save()/restore().

My point is, this will be used under treelock soon.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/