Re: [PATCH 07/11] ST SPEAr: Added source files for SPEAr3xx machine family

From: Linus Walleij
Date: Wed Mar 10 2010 - 00:15:20 EST


2010/3/9 Viresh KUMAR <viresh.kumar@xxxxxx>:

> On 3/9/2010 12:16 PM, Linus Walleij wrote:
>> Hi Viresh,
>>> (...)
>>> +       .irq = {IRQ_UART, NO_IRQ},
>>> +       .periphid = 0x00041011,
>>> +};
>>
>> You're hardcoding the PrimeCell ID to the ARM version, (...)
>
> Actually PL011 is customized by ST's nomadik platform. And hence above
> is true for nomadik only. We are using ARM's version of PL011 without
> any customization over it and so id for our case is still 0x00041011.

OK then you can probably just delete the .periphid line, the only thing that
will do is to override the number found in the ID registers with the same
number. If this doesn't work you certainly have a modified version anyway.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/