Re: [PATCH 2/2] percpu,module: implement and useis_kernel/module_percpu_address()

From: Peter Zijlstra
Date: Wed Mar 10 2010 - 06:35:50 EST


On Wed, 2010-03-10 at 18:57 +0900, Tejun Heo wrote:
> lockdep has custom code to check whether a pointer belongs to static
> percpu area which is somewhat broken. Implement proper
> is_kernel/module_percpu_address() and replace the custom code.
>
> On UP, percpu variables are regular static variables and can't be
> distinguished from them. Always return %false on UP.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>

Looks good to me, thanks Tejun!

Acked-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/