Re: [PATCH 4/5] fs: fat: use hex_asc_lo/hex_asc_hi instead of custom one

From: OGAWA Hirofumi
Date: Thu Mar 11 2010 - 04:03:38 EST


Andy Shevchenko <andy.shevchenko@xxxxxxxxx> writes:

> On Thu, Mar 11, 2010 at 1:18 AM, OGAWA Hirofumi
> <hirofumi@xxxxxxxxxxxxxxxxxx> wrote:
>>> +                             *op++ = hex_asc_hi(ec >> 8);
>>> +                             *op++ = hex_asc_lo(ec >> 8);
>>> +                             *op++ = hex_asc_hi(ec);
>>> +                             *op++ = hex_asc_lo(ec);
>> Why doesn't this use pack_hex_byte()?
> No specific reason, it could be so. Would you like me to change this?

Yes, please change it if you have no problem.

Thanks.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/