Re: [PATCH] base firmware: Fix BUG from sysfs attributes change incommit a2db6842873c8e5a70652f278d469128cb52db70

From: Linus Torvalds
Date: Sun Mar 14 2010 - 14:09:39 EST




On Sun, 14 Mar 2010, Linus Torvalds wrote:
>
> On Sun, 14 Mar 2010, Wolfram Sang wrote:
>
> > http://patchwork.kernel.org/patch/85212/
> > (which is pretty much the same like the patch originating this thread. I vote
> > very much for dropping those patches and use
> > http://patchwork.kernel.org/patch/84814/ instead!)
>
> Also, that "firmware_attr_data" thing should probably be marked 'const',
> no? That should make it more obvious that it's ok to share across multiple
> different firmware file, I think.

Btw, if it wasn't obvious, this was a comment on that

http://patchwork.kernel.org/patch/84814/

patch that would replace the one-liner in 85212.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/