Re: [PATCH] Driver core: Reduce the level of request_firmware() messages

From: Rafael J. Wysocki
Date: Mon Mar 15 2010 - 20:15:35 EST


On Tuesday 16 March 2010, Greg KH wrote:
> On Tue, Mar 16, 2010 at 05:04:09AM +0530, Jaswinder Singh Rajput wrote:
> > Hello Rafael,
> >
> > On Tue, Mar 16, 2010 at 2:57 AM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> > >
> > > I still think it's a good idea. The information about what firmware is being
> > > used doesn't seem to be very useful for anything but debugging, so I think
> > > KERN_DEBUG is actually the right level for these messages.
> > >
> >
> > Can we use printk_once()
>
> No, I'd rather use dev_dbg() that way we can dynamically turn it on and
> off as needed. I took Rafael's original patch.

OK, thanks!

> Funny thing is, someone else also sent the same patch, so there must be
> others wanting this change :)

I know SGI wants it at least.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/