Re: [PATCH] trace power_frequency events on the correct cpu (for Intel x86 CPUs)

From: Thomas Renninger
Date: Tue Mar 16 2010 - 10:50:28 EST


On Tuesday 16 March 2010 15:19:13 Arjan van de Ven wrote:
>
> > But something else...:
> > What exactly is the power tracer good for and what is it
> > capable of which cpufreq_stats is not capable to do?
>
> look at timechart for example.....
> it's extremely useful to have this for us that do power tuning...
Currently even only a small subset of x86 ia supported, I can't see how
useful this is.

> cpufreq_stats is nice but not nearly good enough since you only get
> averages, not time behavior.
As said, try to hook it into cpufreq_stats.
Mark the cpufreq_stats sysfs interface deprecated, etc.

I like the idea of having one central trace utility, which probably
makes it easier for people to find such things.
But please do it properly and CC the cpufreq list in the future.

Still, as this is totally broken:
- by design -> only one of a dozen cpufreq drivers is supported
- by implementation -> wrong CPUs are tracked
please submit my patch and remove this again until a proper
implementation is provided.

Thanks,

Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/