Re: [Suspected SPAM] [PATCH 3/3] SCSI: qla2xxx, fix lock imbalance

[Giridhar Malavali]

On 3/16/10 8:23 AM, "Jiri Slaby" <jslaby@xxxxxxx> wrote:

> Stanse found that one error path in qla24xx_bsg_timeout omits to
> unlock ha->hardware_lock. Fix that.
> 
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Giridhar Malavali <giridhar.malavali@xxxxxxxxxx>
> Cc: James Bottomley <James.Bottomley@xxxxxxx>
> ---
>  drivers/scsi/qla2xxx/qla_attr.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
> index 90d1e06..a3591e5 100644
> --- a/drivers/scsi/qla2xxx/qla_attr.c
> +++ b/drivers/scsi/qla2xxx/qla_attr.c
> @@ -2388,6 +2388,7 @@ qla24xx_bsg_timeout(struct fc_bsg_job *bsg_job)
>         return 0;
> 
>  done:
> +       spin_unlock_irqrestore(&ha->hardware_lock, flags);
>         if (bsg_job->request->msgcode == FC_BSG_HST_CT)
>                 kfree(sp->fcport);
>         kfree(sp->ctx);
> --
> 1.7.0.1
> 
> 
Acked-by: Giridhar Malavali <giridhar.malavali@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/