Re: [Patch] netpoll: allow spaces in its parameter

[Cong Wang]

David Miller wrote:
> From: Amerigo Wang <amwang@xxxxxxxxxx>
> Date: Wed, 17 Mar 2010 01:53:26 -0400
>
> > It would be nice if we allow spaces in netconsole parameters,
> > otherwise we get weird results if there are spaces in it.
> >
> > After this patch, we will allow things like:
> >  "netconsole= @192.168.0.1/eth0 , 66666@xxxxxxxxxxx/".
> >
> > Signed-off-by: WANG Cong <amwang@xxxxxxxxxx>
> > Cc: David Miller <davem@xxxxxxxxxxxxx>
>
> That kernel command line looks absolutely awful, not
> better.
>
> Sorry I'm not applying this.

The problem is that the dst port is 0 when I even use:

"netconsole=@xxxxxxxxxxx/eth0, 66666@xxxxxxxxxxx/"

This is awful too? I don't think so...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/