Re: [PATCH v2] KVM: cleanup {kvm_vm_ioctl, kvm}_get_dirty_log()

[Xiao Guangrong]

Takuya Yoshikawa wrote:

> 
> Oh, for such a tiny comment.

Your comment is valuable although it's tiny :-)

> 

> 
> What I said was just you may be able to use bitmap_empty() instead of
> 
>> -    for (i = 0; !is_dirty && i < n/sizeof(long); i++)
>> -        is_dirty = memslot->dirty_bitmap[i];
> 
> for x86's code too, if your patch for kvm_get_dirty_log() was correct.

While i look into x86's code, i found we can direct call kvm_get_dirty_log()
in kvm_vm_ioctl_get_dirty_log() to remove some unnecessary code, this is a
better cleanup way

Thanks,
Xiao
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/