Re: [Patch] netpoll: warn when there are spaces in parameters

From: Frans Pop
Date: Wed Mar 17 2010 - 06:58:59 EST


Amerigo Wang wrote:
> + if (*cur == ' ' || *cur == '\t')
> + printk(KERN_INFO "%s: warning: white spaces"
> + "are not allowed.\n", np->name);
>

The term "white spaces" not correct. Please change the message to
"whitespace is not allowed".

Also, it's normally not necessary to close kernel messages with a period;
most kernel messages do not have a closing period. Messages are not
sentences and the periods only help increase the kernel size.

Thanks,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/