Re: [PATCH 1/1] infiniband: ulp/iser, fix error retval iniser_create_ib_conn_res

[Dan Carpenter]

On Tue, Mar 16, 2010 at 04:52:43PM -0700, Roland Dreier wrote:
>  >  	ib_conn->login_buf = kmalloc(ISER_RX_LOGIN_SIZE, GFP_KERNEL);
>  >  	if (!ib_conn->login_buf) {
>  > -		goto alloc_err;
>  >  		ret = -ENOMEM;
>  > +		goto alloc_err;
>  >  	}
> 
> This looks like a valid fix but it's the same part of the code that Dan
> found more extensive bugs in.  Or, can I assume you'll sort this out and
> make sure a final patch is sorted out?
> 

My patch is the one to take.  It addresses this problem here and fixes
some double frees.

http://marc.info/?l=linux-rdma&m=126872745710910&w=2

Sorry about that Jiri.  Btw. Julia Lawall, Daren Jenkins and I normally CC 
kernel-janitors for static checker patches.

regards,
dan carpenter

> Thanks,
>   Roland
> -- 
> Roland Dreier  <rolandd@xxxxxxxxx>
> For corporate legal information go to:
> http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/