Re: [PATCH 13/24] mfd: fix dangling pointers

From: Mark Brown
Date: Sat Mar 20 2010 - 13:22:48 EST


On Sat, Mar 20, 2010 at 03:12:54PM +0100, Wolfram Sang wrote:
> Fix I2C-drivers which missed setting clientdata to NULL before freeing the
> structure it points to. Also fix drivers which do this _after_ the structure
> was freed already.

Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

but it really does seem like this is something that the I2C core ought
to handle - the assignment to null is boiler plate code that's getting
added to the overwhelming majority of I2C devices in their teardown
path, it'd seem a lot more sensible for the core to just trash driver
data after the driver is unbound if it's important that this happens.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/