Re: [Regression, post-2.6.34-rc1][PATCH] x86 / perf: Fix suspend toRAM on HP nx6325

From: Linus Torvalds
Date: Sat Mar 20 2010 - 13:52:18 EST




On Sat, 20 Mar 2010, Peter Zijlstra wrote:
>
> cpuhw = &per_cpu(cpu_hw_events, cpu);
> + if (!cpuhw)
> + return;

How can an address-of expression be NULL?

Yes, 'per_cpu()' is magic, but it shouldn't be possible to be _that_
magic. It's rather against the whole C model.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/