Re: [PATCH v2 2/6] hid: add framebuffer support to PicoLCD device

[Jiri Kosina]

On Sun, 21 Mar 2010, Bruno PrÃmont wrote:

> > > ---
> > > Âdrivers/hid/Kconfig    |  Â7 +-
> > > Âdrivers/hid/hid-picolcd.c | Â454 +++++++++++++++++++++++++++++++++++++++++++++
> > > Â2 files changed, 460 insertions(+), 1 deletions(-)
> > 
> > It is customary for framebuffer drivers to live in drivers/video. This
> > is the first one I've reviewed that is outside of it. Is there a good
> > reason for this one to be outside of it? If so, could you put it in
> > the comments.
> 
> I've kept all the pieces of PicoLCD driver together under hid,
> as it's a HID based device. Framebuffer is just one of its features and
> keeping pieces together makes it easier to handle.

I think it makes sense for a HID driver for this device to contain the 
framebuffer bits as well ... from user perspective, this seems to be HID 
device, with "extra" framebuffer display on it.

If framebuffer folks Ack the fb-related code, I am fine keeping it under 
drivers/hid.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/