Re: [PATCH] mm/nommu.c:Dynamic alloc/free percpu area for nommu

[David Howells]

<graff.yang@xxxxxxxxx> wrote:

> -	return virt_to_page(addr);
> +	return (struct page *)
> +			(virt_to_page(addr)->index) ? : virt_to_page(addr);

Can the extra conditional operator be made subject to CONFIG_SMP?

> -	return page_to_pfn(virt_to_page(addr));
> +	return page_to_pfn((struct page *)
> +			(virt_to_page(addr)->index) ? : virt_to_page(addr));

Ditto.

> +#ifdef CONFIG_SMP
> ...
> +#endif

Can this be put into a separate file?  There's rather a lot in mm/nommu.c
these days.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/