Re: [patch] mfd: off by one calculating size

From: Richard Röjfors
Date: Mon Mar 22 2010 - 08:38:01 EST


On 03/22/2010 01:12 PM, Dan Carpenter wrote:
I'm pretty sure that it should be + 1 here. It's an off by one, because
we start counting at zero.

You are completely right, fortunately we don't access the last register.

Signed-off-by: Dan Carpenter<error27@xxxxxxxxx>

Acked-by: Richard Röjfors <richard.rojfors@xxxxxxxxxxxxxx>

---
Found by a static checker and untested. Please review carefully.

diff --git a/drivers/mfd/timberdale.h b/drivers/mfd/timberdale.h
index 8d27ffa..902c451 100644
--- a/drivers/mfd/timberdale.h
+++ b/drivers/mfd/timberdale.h
@@ -66,7 +66,7 @@

#define CHIPCTLOFFSET 0x800
#define CHIPCTLEND 0x8ff
-#define CHIPCTLSIZE (CHIPCTLEND - CHIPCTLOFFSET)
+#define CHIPCTLSIZE (CHIPCTLEND - CHIPCTLOFFSET + 1)

#define INTCOFFSET 0xc00
#define INTCEND 0xfff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/