Re: [rfc][patch] mm, fs: warn on missing address space operations

From: Nick Piggin
Date: Mon Mar 22 2010 - 17:02:11 EST


On Mon, Mar 22, 2010 at 09:30:41AM -0400, Andrew Morton wrote:
> On Mon, 22 Mar 2010 21:40:57 +1100 Nick Piggin <npiggin@xxxxxxx> wrote:
>
> > >
> > > /* this fs should use block_invalidatepage() */
> > > WARN_ON_ONCE(!invalidatepage);
> >
> > Problem is that it doesn't give you the aop name (and call trace
> > probably won't help).
>
> Yes it does - you have the filename and line number. You go there and
> read "invalidatepage". And the backtrace identifies the filesystem.

The backtrace is usually coming from just generic code paths though.
Granted that it's usually not too hard to figure what filesystem it is
(although it may have several aops).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/