Re: [PATCH] S3C RTC driver: add support for S3C64xx

[Maurus Cuelenaere]

"Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

>On Mon, 22 Mar 2010 12:26:48 +0100 Maurus Cuelenaere <mcuelenaere@xxxxxxxxx> wrote:
>
>> Add support for the S3C64xx SoC to the generic S3C RTC driver.
>> 
>> Signed-off-by: Maurus Cuelenaere <mcuelenaere@xxxxxxxxx>
>> Acked-By: Ben Dooks <ben-linux@xxxxxxxxx>
>> ---
>> 
>> This was sent to rtc-linux before (12/01/2010), but no response was
>> received yet.
>> See http://groups.google.com/group/rtc-linux/browse_thread/thread/2a2dfc23a8042f3d/2812dcbafd9a0a85
>> for the full thread.
>> 
>> At 08/03/2010 I posted this to LKML, with no result.
>> On recommendation of Frans Pop, I resend this to LKML with Andrew Morton in CC.
>> 
>> The platform part of this patch has been included in 2.6.34-rc2.
>> 
>>  arch/arm/plat-s3c/include/plat/regs-rtc.h |    4 +
>
>That was sneaky.  I assume that
>arch/arm/plat-s3c/include/plat/regs-rtc.h is a symlink to
>arch/arm/plat-samsung/include/plat/regs-rtc.h on your machine - it
>doesn't exist on mine.  I fixed the patch so it patches the correct
>path.

That's correct, I probably forgot to update it with the plat-s3c -> plat-samsung move, sorry about that.

>>  drivers/rtc/Kconfig                       |    2 +-
>>  drivers/rtc/rtc-s3c.c                     |  107 +++++++++++++++++++++++------
>>  3 files changed, 92 insertions(+), 21 deletions(-)
>
>The patch had a bit of wordwrapping.  Please watch out for these things
>next time.

Odd, I specifically didn't use Thunderbird to eliminate any wordwrapping..


Thanks for accepting!

--
Maurus Cuelenaere