Re: [PATCH 05/11] Export unusable free space index via/proc/unusable_index

[Christoph Lameter]

On Tue, 23 Mar 2010, Mel Gorman wrote:

> +/*
> + * Return an index indicating how much of the available free memory is
> + * unusable for an allocation of the requested size.
> + */
> +static int unusable_free_index(unsigned int order,
> +				struct contig_page_info *info)
> +{
> +	/* No free memory is interpreted as all free memory is unusable */
> +	if (info->free_pages == 0)
> +		return 1000;


Is that assumption correct? If you have no free memory then you do not
know about the fragmentation status that would result if you would run
reclaim and free some memory. Going into a compaction mode would not be
useful. Should this not return 0 to avoid any compaction run when all
memory is allocated?

Otherwise

Reviewed-by: Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/