Re: [PATCH] Introduce freeze_super and thaw_super for the fsfreezeioctl

[Nigel Cunningham]

Hi.

On 24/03/10 11:21, Al Viro wrote:
> On Wed, Mar 24, 2010 at 10:55:45AM +1100, Nigel Cunningham wrote:
> > Hi again.
> >
> > On 24/03/10 10:52, Nigel Cunningham wrote:
> > > > I've stayed away from TuxOnIce flamefests and I've no idea how
> > > > representative
> > > > that snippet is, but if it *does* match the general code quality in
> > > > there...
> > > > Ouch.
> > >
> > > Locking isn't necessary because of the freezing.
> >
> > Err, freezer, I mean.
>
> Even leaving aside the accuracy of that (and I seriously doubt it), this
> is completely wrong since *code* *gets* *copied*.

Ok. That's a fair enough point. I'll add locking.

Regards,

Nigel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/