Re: [PATCH] Introduce freeze_super and thaw_super for the fsfreezeioctl

[Nigel Cunningham]

Hi.

On 24/03/10 12:17, Josef Bacik wrote:
> On Wed, Mar 24, 2010 at 09:25:39AM +1100, Nigel Cunningham wrote:
> > Hi.
> >
> > A cc would have been nice :)
> >
> > Thankfully the subject caught my eye.
>
> Well it's not really tux-on-ice's fault, freeze wouldn't work _at all_ via the
> ioctl or any other method, we just happened to notice it was broken because
> people using tux-on-ice were getting corrupt filesystems after suspend :).  Btw,
> it may be good to have freezer_sync set to 1 by default, otherwise if an fs
> doesnt support freezing it will likely end up corrupted too.  Thanks,

Corrupted because the sys_sync was disabled? (We were recently 
discussing adding a tuneable to swsusp for disabling sys_sync there too).

I've just committed a patch making freezer_sync default to 1.

Regards,

Nigel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/