Re: [PATCH 2/2] [BUGFIX] pagemap: fix pfn calculation for hugepage

[Naoya Horiguchi]

On Fri, Mar 19, 2010 at 05:13:10PM +0900, KAMEZAWA Hiroyuki wrote:
...
> > 
> > But, this means hugeltb_entry() is not called per hugetlb entry...isn't it ?
> > 
> > Why hugetlb_entry() cannot be called per hugeltb entry ? Don't we need a code
> > for a case as pmd_size != hugetlb_size in walk_page_range() for generic fix ?
> > 
> 
> How about this style ? This is an idea-level patch. not tested at all.
> (I have no test enviroment for multiple hugepage size.)
> 
> feel free to reuse fragments from this patch.
>

So the point is calling hugetlb_entry() for each huge page, right?

It looks good.
I've rewritten my patch based on your idea and make sure it works.
Is it ok to add your Signed-off-by?

Thanks,
Naoya Horiguchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/