Re: [PATCH 1/4] hwmon: f71882fg: Add support for the Fintek F71808E

[Hans de Goede]

Hi,

On 03/24/2010 10:23 AM, Giel van Schijndel wrote:
> On Wed, Mar 24, 2010 at 09:25:08AM +0100, Hans de Goede wrote:
> > See comments inline.
> >
> > On 03/24/2010 12:12 AM, Giel van Schijndel wrote:
> > > Allow device probing to recognise the Fintek F71808E.
> > >
> > > Sysfs interface:
> > >    * Fan/pwm control is the same as for F71889FG
> > >    * Temperature and voltage sensor handling is largely the same as for
> > >      the F71889FG
> > >     - Has one temperature sensor less (doesn't have temp3)
> > >     - Misses one voltage sensor (doesn't have V6, thus in6_input refers to
> > >       what in7_input refers for F71889FG)
> > >
> > > For the purpose of the sysfs interface fxxxx_in_temp_attr[] is split up
> > > such that it can largely be reused.
> > > ---
> > >    Documentation/hwmon/f71882fg |    4 ++
> > >    drivers/hwmon/Kconfig        |    6 ++--
> > >    drivers/hwmon/f71882fg.c     |   80 +++++++++++++++++++++++++++++++++++++----
> > >    3 files changed, 79 insertions(+), 11 deletions(-)
> > >
> > > diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c
> > > index 25e1cad..b290b87 100644
> > > --- a/drivers/hwmon/f71882fg.c
> > > +++ b/drivers/hwmon/f71882fg.c
> > > @@ -1974,8 +2002,27 @@ static int __devinit f71882fg_probe(struct platform_device *pdev)
> > >    			/* fall through! */
> > >    		case f71862fg:
> > >    			err = f71882fg_create_sysfs_files(pdev,
> > > -					fxxxx_in_temp_attr,
> > > -					ARRAY_SIZE(fxxxx_in_temp_attr));
> > > +					f71862_temp_attr,
> > > +					ARRAY_SIZE(f71862_temp_attr));
> > > +			if (err)
> > > +				goto exit_unregister_sysfs;
> > > +			err = f71882fg_create_sysfs_files(pdev,
> > > +					fxxxx_in_attr,
> > > +					ARRAY_SIZE(fxxxx_in_attr));
> > > +			if (err)
> > > +				goto exit_unregister_sysfs;
> > > +			/* fall through! */
> >
> > Ugh, please don't fall through, and then have an if below to only do
> > some parts of the case falling through. This is quite confusing
> > at first I thought your code was buggy I had to read it twice to notice
> > the if. Instead just duplicate the following lines:
> > > +			err = f71882fg_create_sysfs_files(pdev,
> > > +					fxxxx_temp_attr,
> > > +					ARRAY_SIZE(fxxxx_temp_attr));
> > In the f71862fg case, end the f71862fg case with a break and remove
> > the if test from the f71808fg case.
> >
> > > +		case f71808fg:
> > > +			if (data->type == f71808fg) {
> > > +				err = f71882fg_create_sysfs_files(pdev,
> > > +						f71808_in_attr,
> > > +						ARRAY_SIZE(f71808_in_attr));
> > > +				if (err)
> > > +					goto exit_unregister_sysfs;
> > > +			}
> > > +			err = f71882fg_create_sysfs_files(pdev,
> > > +					fxxxx_temp_attr,
> > > +					ARRAY_SIZE(fxxxx_temp_attr));
> > >    			break;
> > >    		case f8000:
> > >    			err = f71882fg_create_sysfs_files(pdev,
> > > @@ -2126,8 +2175,20 @@ static int f71882fg_remove(struct platform_device *pdev)
> > >    			/* fall through! */
> > >    		case f71862fg:
> > >    			f71882fg_remove_sysfs_files(pdev,
> > > -					fxxxx_in_temp_attr,
> > > -					ARRAY_SIZE(fxxxx_in_temp_attr));
> > > +					f71862_temp_attr,
> > > +					ARRAY_SIZE(f71862_temp_attr));
> > > +			f71882fg_remove_sysfs_files(pdev,
> > > +					fxxxx_in_attr,
> > > +					ARRAY_SIZE(fxxxx_in_attr));
> > > +			/* fall through! */
> >
> > Idem.
>
> Ack. New and improved patch follows this line.
> ========================================================================
> hwmon: f71882fg: Add support for the Fintek F71808E

This new version looks good to me:
Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/