Re: [PATCH -v4 00/08] use lmb with x86

From: Michael Ellerman
Date: Wed Mar 24 2010 - 07:41:18 EST


On Wed, 2010-03-24 at 11:48 +0100, Ingo Molnar wrote:
> * Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>
> > new early_res is lmb extension. and it could be used to replace bootmem.
>
> Why not do what we suggested: extend lmb.c to also offer the
> early_res-equivalent functionality, and remove kernel/early_res.c and move
> lib/lmb.c to mm/lmb.c?
>
> We dont want two facilities (early_res and lmb) really ...

Exactly.

This series seems to leave us with kernel/early_res.c (which should
never have moved out of arch/x86 AFAICS) - as well as using some of
lmb.c.

It doesn't compile on powerpc, because early_res.c is looking for
find_fw_memmap_area() which is still under arch/x86.

And sprinkling CONFIG_NO_BOOTMEM everywhere is getting a bit gross. I
notice that's already happened to mm/(bootmem|page_alloc).c but
propagating it further is not nice.

cheers

Attachment: signature.asc
Description: This is a digitally signed message part