Re: [PATCH 2/4] dmaengine: Xilinx MPMC Kconfig/make

[Dan Williams]

On Wed, Mar 17, 2010 at 9:26 AM, Steven J. Magnani
<steve@xxxxxxxxxxxxxxx> wrote:
> Integrate xlldma drivers into the build.
>
> Signed-off-by: Steven J. Magnani <steve@xxxxxxxxxxxxxxx>
> ---
> diff -uprN a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> --- a/drivers/dma/Kconfig       2010-03-16 13:27:42.000000000 -0500
> +++ b/drivers/dma/Kconfig       2010-03-17 11:11:57.000000000 -0500
> @@ -126,6 +126,28 @@ config AMCC_PPC440SPE_ADMA
>        help
>          Enable support for the AMCC PPC440SPe RAID engines.
>
> +config XLL_DMA
> +       tristate "Xilinx LocalLink DMA support"
> +       depends on XILINX_VIRTEX || MICROBLAZE
> +       select DMA_ENGINE
> +       ---help---
> +         Enable support for the Xilinx MPMC DMA controller.
> +         This requires at least one MPMC SDMA port wired as a "loopback".
> +
> +         If unsure, say N.
> +
> +config XLL_DMA_OF
> +        tristate "Xilinx LocalLink DMA OF device"
> +        depends on XLL_DMA && OF
> +        help
> +          OpenFirmware bus attachment for the Xilinx LocalLink DMA engine.
> +
> +config XLL_DMA_PLAT
> +        tristate "Xilinx LocalLink DMA platform device"
> +        depends on XLL_DMA
> +        help
> +          Platform bus attachment for the Xilinx LocalLink DMA engine.

I think these should be in the per-arch Kconfig, if at all.

> +
>  config ARCH_HAS_ASYNC_TX_FIND_CHANNEL
>        bool
>
> @@ -138,13 +160,13 @@ comment "DMA Clients"
>  config NET_DMA
>        bool "Network: TCP receive copy offload"
>        depends on DMA_ENGINE && NET
> -       default (INTEL_IOATDMA || FSL_DMA)
> +       default (INTEL_IOATDMA || FSL_DMA || XLL_DMA)

NET_DMA is actively harmful for platforms with a non-io-coherent
caches.  So it should not default to y on Microblaze.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/