gpiolib: irq functions not implemented on x86

From: JÃrÃme Oufella
Date: Thu Mar 25 2010 - 15:42:25 EST


Hi,

I wrote a gpiolib implementation for Technologic Systems TS-5500 boards (x86)
custom GPIO lines. Some of their GPIO lines are directly hooked to CPU (ElanSC520)
GPIRQ lines, so they can trigger IRQs.

However, looking at arch/x86/include/asm/gpio.h:
/*
* Not implemented, yet.
*/
static inline int gpio_to_irq(unsigned int gpio)
{
return -ENOSYS;
}

gpio_to_irq()/irq_to_gpio() are not defined on x86 yet.

Q: Is there a reason not to have it call gpiolib's __gpio_to_irq(), as done
for other gpiolib functions defined here ? such as

- return -ENOSYS;
+ return __gpio_to_irq(gpio);


Thanks
Jerome Oufella
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/