Re: [linux-pm] [RFC 03/15] PM / Hibernate: separate block_io

From: Nigel Cunningham
Date: Thu Mar 25 2010 - 16:12:16 EST


Hi.

On 26/03/10 07:12, Rafael J. Wysocki wrote:
On Thursday 25 March 2010, Nigel Cunningham wrote:
Hi again.

On 25/03/10 09:58, Nigel Cunningham wrote:
Hi.

On 25/03/10 08:22, Jiri Slaby wrote:
On 03/24/2010 09:30 PM, Pavel Machek wrote:
On Tue 2010-03-23 17:17:31, Jiri Slaby wrote:
+int sws_bio_read_page(pgoff_t page_off, void *addr, struct bio **bio_chain)
+{
+ return submit(READ, sws_resume_bdev, page_off * (PAGE_SIZE>> 9),
+ virt_to_page(addr), bio_chain);
+}

sws_ is kind of strange prefix. We were trying to get away from
"swsuspend" name for quite some time...

No problem to change the prefix to anything else. Do you (anybody)
suggest anything?


How about some abbreviation of hibernate? "hib"?

On further reflection, how about "std" (suspend to disk)? I think that's
less ugly than the 'hib' suggestion :)

But it also decodes as "standard" if someone is not in the right context. :-)

Ah...

If the "bio" part of the name is not essential (ie. there's no conflicting name
already), we could call it simply hibernate_read_page().

Yeah. So we're going with hibernate or hib_ if it needs abbreviating?

Nigel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/